Syntax Exception while creating an apoc procedure inside a apoc trigger

[mohammedfarazal]

I am creating an apoc procedure inside a apoc trigger. The error in the logs says this
"
org.neo4j.exceptions.SyntaxException: Variable node not defined (line 1, column 26 (offset: 25))
"MATCH(p1:SPerson { name: node.name}) CREATE (p1)-[:Enrolled]->(c)"

"

My apoc trigger code

 CALL apoc.trigger.add('loadEnrollments',   
"UNWIND apoc.trigger.nodesByLabel($assignedLabels, 'Enrollment') AS node
 MERGE (p1:SPerson { name: node.name, cell: node.cell, created_at: node.created_at})
 WITH p1, node
 MATCH (c:Course {name: 'Paradigm Shifting 101'})
 MATCH (n:SPerson)
 WITH p1, node, COUNT(n) as size
 CALL apoc.do.when(
 size>3,'MERGE (p1)-[:Waitlist]->(c)',
 'MATCH(p1:SPerson { name: node.name}) CREATE (p1)-[:Enrolled]->(c)') YIELD value
 DETACH DELETE node", 
 { phase: 'after' });

[stefan_armbrust]

your apoc.do.when call lacks passing through the parameters for p1 and c, see https://neo4j.com/docs/labs/apoc/current/cypher-execution/conditionals/

[mohammedfarazal]

Thanks Stefan. That worked.
Can you also please suggest me something on the following question. Your expertise is greatly appreciated.

Neo4j- questions on Syntax of apoc trigger, procedure and WITH statements Procedures & APOC

I have the following APOC trigger which contains a apoc procedure. This works as desired but I am wondering if I used a lot of WITH statements, is that the way to go? or is there a better way to refactor this code. I am still new to neo4j so not sure. The control flow- Whenever the Enrollment node is created, it creates an SPerson node and depending on the size(number of SPerson nodes) it creates an enrolled or waitlist(if size>3, and deletes enrolled relation) relation with the course node. T…