SDN Repository Pagination not ready for Neo4J 4.0

[p_suettner]

Hi,

we are using spring-boot-starter-data-neo4j-2.2.4.RELEASE (spring-data-neo4j-5.2.4.RELEASE) and Neo4J 4.0 database server.

Using custom queries (@Query annotation) with pagination in repositories is currently causing an error, because SDN generates a query using the old parameter syntax for binding the SKIP and LIMIT parameters.

See:

github.com

spring-projects/spring-data-neo4j/blob/5.2.x/spring-data-neo4j/src/main/java/org/springframework/dat...

* sort to the string based queries as OGM does not support pagination and sort on those.
*
* @author Nicolas Mervaillie
* @author Michael J. Simons
* @author Ihor Dziuba
*/
public class Query {


	private static final String SKIP = "sdnSkip";
	private static final String LIMIT = "sdnLimit";
	private static final String SKIP_LIMIT = " SKIP {" + SKIP + "} LIMIT {" + LIMIT + "}";
	private static final String ORDER_BY_CLAUSE = " ORDER BY %s";


	private Filters filters;
	private String cypherQuery;
	private Map<String, Object> parameters;
	private @Nullable String countQuery;


	public Query(Filters filters) {
		Assert.notNull(filters, "Filters must not be null.");
		this.filters = filters;

Is this a known issue and are there any plans to fix this in upcoming releases?

Greetings,

Peter

[gerrit_meier]

Thanks for reporting this. It came up a few days ago on StackOverflow.

We will fix in every supported Spring Data version (5.1, 5.2 and the upcoming 5.3).
There is a Jira ticket or this pull request that you can track.